[cfe-commits] [Patch][Review] PR13329 - Incorrect code generated for automatic assignment operator

[John McCall]

On Aug 15, 2012, at 8:23 AM, Jonathan Sauer wrote:
>> Sorry for only noticing it now, but I think the check lines are wrong.
>> Instead of
>> 
>> // CHECK OBJ: {{call.*_ZN1AaSERS_}}
>> 
>> You should have
>> 
>> // CHECK-OBJ: {{call.*_ZN1AaSERS_}}
> 
> I think it still worked as intended because the prefix was just "OBJ", so the "CHECK" was ignored.
> But it's obfuscating so I corrected it. New patch attached, please commit :-)

Sorry for the many delays.  I committed this as r162254 with a few tweaks.

To answer the question in your patch, DerivedPOD is not POD for the purposes of the Itanium ABI because the ABI uses the C++98 POD rules (and must — doing otherwise would break binary compatibility), which do not consider classes with base classes to be POD.

John.