[cfe-commits] [PATCH] Terse output mode for DeclPrinter and lots of tests

Dmitri Gribenko gribozavr at gmail.com
Mon Aug 20 16:40:51 PDT 2012


On Mon, Aug 20, 2012 at 4:33 PM, Douglas Gregor <dgregor at apple.com> wrote:
> On Aug 17, 2012, at 5:49 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> The attached patch adds a flag
>> PrintingPolicy::DontRecurseInDeclContext to provide "terse" output
>> from DeclPrinter.  The motivation is to use DeclPrinter to print
>> declarations in user-friendly format, without overwhelming user with
>> inner detail of the declaration being printed.
>>
>> This patch also adds many tests for DeclPrinter.  There are quite a
>> few things that we print incorrectly: search for WRONG in test file --
>> and these tests check our output against incorrect output, so that we
>> can fix/refactor/rewrite the DeclPrinter later.
>
> Patch LGTM. We can evolve the tests and the DeclPrint to be less broken over time. Thanks!

Thank you for the review, committed r162245.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list