[cfe-commits] [PATCH] Make clang::driver::Option non virtual. First steps to extracting option parsing from clang.

Daniel Dunbar daniel at zuster.org
Mon Aug 20 14:07:07 PDT 2012


Hey Michael,

LGTM. It might be a bit cleaner to have isFlag() etc. type methods on
the Option class instead of having client code check the kind
directly.

 - Daniel

On Fri, Aug 17, 2012 at 4:47 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
> The attached patch makes the clang::driver::Option class have no virtual
> members. It also gets rid of all of its subclasses. The end goal of the
> clang::driver::Option refactoring is to make it a value type that has a single
> OptTable::Info* member. Each OptTable will return its own subclass of Option
> that interprets the flag bits.
>
> - Michael Spencer



More information about the cfe-commits mailing list