[cfe-commits] r161698 - in /cfe/trunk: include/clang/AST/Stmt.h lib/AST/Stmt.cpp lib/Sema/SemaStmt.cpp

[NAKAMURA Takumi]

2012/8/11 Chad Rosier <mcrosier at apple.com>:
> Author: mcrosier
> Date: Fri Aug 10 16:06:19 2012
> New Revision: 161698
>
> URL: http://llvm.org/viewvc/llvm-project?rev=161698&view=rev
> Log:
> [ms-inline asm] Fix a memory leak introduced in r161686.

> --- cfe/trunk/lib/Sema/SemaStmt.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaStmt.cpp Fri Aug 10 16:06:19 2012
> @@ -2883,7 +2883,7 @@
>                                  SourceLocation EndLoc) {
>    // MS-style inline assembly is not fully supported, so emit a warning.
>    Diag(AsmLoc, diag::warn_unsupported_msasm);
> -  SmallVector<std::string,4> Clobbers;
> +  SmallVector<StringRef,4> Clobbers;

Capturing loop-scoped (std::string)Reg with StringRef would be bad thing.

+      Clobbers.push_back(Reg);

I guess it triggered failure on some builders since your r161914.

...Takumi