[cfe-commits] r161650 - in /cfe/trunk: include/clang/Frontend/VerifyDiagnosticConsumer.h lib/ARCMigrate/ARCMT.cpp lib/Frontend/VerifyDiagnosticConsumer.cpp test/ARCMT/verify.m test/ASTMerge/function.c test/Frontend/verify.c test/Frontend/verify2.c test/Frontend/veri

Vassil Vassilev vvasilev at cern.ch
Tue Aug 14 11:09:05 PDT 2012


Hi Andy,
   Thanks for the both patches! It's amazing how quickly you find your 
way in cling!
   The second patch is what we exactly need.
Thanks a lot for your time,
Vassil
On 8/14/12 7:02 PM, Andy Gibbs wrote:
> Hi,
>
> Attached is an improvement to the backup checking algorithm that better
> supports cling's use-case.
>
> In terms of general operation (i.e. in terms of clang's test-suite), the
> functionality is unchanged.  Instead of maintaining two separate lists
> for files with diagnostics and those parsed for directives, a single list
> is now held, and implemented as a DenseMap with the key as FileID and
> the value as a pair of FileEntry* and a bool indicating whether the file
> has been parsed for directives or not.
>
> It is important, as stated elsewhere in this thread, to keep FileEntry*
> so that FileID aliases can be detected (as is necessary with PCHs, for
> example).
>
> The testing I was able to do with cling suggests that the problem there
> is now solved.
>
> Jordan, ok to commit?
>
> Cheers
> Andy
>




More information about the cfe-commits mailing list