[cfe-commits] r161876 - /cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp

[Ted Kremenek]

Thank you!

Anna Zaks wrote:
> Author: zaks
> Date: Tue Aug 14 10:39:13 2012
> New Revision: 161876
>
> URL: http://llvm.org/viewvc/llvm-project?rev=161876&view=rev
> Log:
> [analyzer] Remove other #if 0 from Retain Count checker.
>
> These date back to 2009, 2011.
>
> Modified:
>      cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
>
> Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp?rev=161876&r1=161875&r2=161876&view=diff
> ==============================================================================
> --- cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp (original)
> +++ cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp Tue Aug 14 10:39:13 2012
> @@ -1107,18 +1107,6 @@
>       if (S)
>         break;
>
> -    // Enable this code once the semantics of NSDeallocateObject are resolved
> -    // for GC.<rdar://problem/6619988>
> -#if 0
> -    // Handle: NSDeallocateObject(id anObject);
> -    // This method does allow 'nil' (although we don't check it now).
> -    if (strcmp(FName, "NSDeallocateObject") == 0) {
> -      return RetTy == Ctx.VoidTy
> -        ? getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, Dealloc)
> -        : getPersistentStopSummary();
> -    }
> -#endif
> -
>       if (RetTy->isPointerType()) {
>         // For CoreFoundation ('CF') types.
>         if (cocoa::isRefType(RetTy, "CF", FName)) {
> @@ -1591,28 +1579,12 @@
>
>     addClassMethSummary("NSWindow", "alloc", NoTrackYet);
>
> -#if 0
> -  addInstMethSummary("NSWindow", NoTrackYet, "initWithContentRect",
> -                     "styleMask", "backing", "defer", NULL);
> -
> -  addInstMethSummary("NSWindow", NoTrackYet, "initWithContentRect",
> -                     "styleMask", "backing", "defer", "screen", NULL);
> -#endif
> -
>     // For NSPanel (which subclasses NSWindow), allocated objects are not
>     //  self-owned.
>     // FIXME: For now we don't track NSPanels. object for the same reason
>     //   as for NSWindow objects.
>     addClassMethSummary("NSPanel", "alloc", NoTrackYet);
>
> -#if 0
> -  addInstMethSummary("NSPanel", NoTrackYet, "initWithContentRect",
> -                     "styleMask", "backing", "defer", NULL);
> -
> -  addInstMethSummary("NSPanel", NoTrackYet, "initWithContentRect",
> -                     "styleMask", "backing", "defer", "screen", NULL);
> -#endif
> -
>     // Don't track allocated autorelease pools yet, as it is okay to prematurely
>     // exit a method.
>     addClassMethSummary("NSAutoreleasePool", "alloc", NoTrackYet);
> @@ -2831,15 +2803,7 @@
>                                                             ResultTy));
>
>         // FIXME: Add a flag to the checker where allocations are assumed to
> -      // *not* fail. (The code below is out-of-date, though.)
> -#if 0
> -      if (RE.getKind() == RetEffect::OwnedAllocatedSymbol) {
> -        bool isFeasible;
> -        state = state.assume(loc::SymbolVal(Sym), true, isFeasible);
> -        assert(isFeasible&&  "Cannot assume fresh symbol is non-null.");
> -      }
> -#endif
> -
> +      // *not* fail.
>         break;
>       }
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits