[cfe-commits] pr12328 PATCH: Friend method declaration doesn't require method to be visible

[Nikola Smiljanic]

Hi Stepan,

I can confirm that both patches fix the issue, but I'm in no position
to review the implementation. I've added John McCall to CC as he seems
to be the owner of the Access code.

However I do have few nits:

There are two unnecessary spaces at the end of your change in SemaDeclCXX.cpp.

AccessTarget parameter of CheckAccessNow function is not aligned
properly, you should indent it by two spaces.

The && in the assert condition inside CheckLookupAccessNow should be
on the previous line, the same probably goes for assert in
CheckLookupAccess (I'm guessing that you copied code from there :).

Thanks for getting back to this.