[cfe-commits] [PATCH] Documentation diagnostics: warn on duplicate commands

[Dmitri Gribenko]

On Mon, Aug 6, 2012 at 8:25 AM, Douglas Gregor <dgregor at apple.com> wrote:
> On Aug 3, 2012, at 11:04 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> Some wording nits:
>
> +def warn_doc_block_command_duplicate : Warning<
> +  "command '\\%0' is duplicate">,
> +  InGroup<Documentation>, DefaultIgnore;
> +
>
> How about "duplicated command '\\%0'"?
>
> +def note_doc_block_command_previous : Note<
> +  "previous command here">;
> +
> +def note_doc_block_command_aliases : Note<
> +  "commands '\\%0' and '\\%1' are aliases">;
>
> Can we merge these together, so that the 'duplicate' warning doesn't end up with two notes? For example:
>
> +def note_doc_block_command_previous : Note<
> +  "previous command '\\%0' here">;
> +
> +def note_doc_block_command_previous_alias : Note<
> +  "previous command '\\%1' (an alias of '\\%0') here">;

Oh, thank you!  I was looking for a merged note wording, but could not
find a good one.

Committed with wording changes in r161325.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/