[cfe-commits] [PATCH] Adjust some linker flags for FreeBSD

[Rafael Espíndola]

> Well, the set of arches that support the flag seems smaller than the set
> that don't.  For example, the flag isn't supported on mips, which
> already has 4 variants.  I also tried using a switch statement earlier,
> but it makes it even more verbose, sort of.

Ah, OK.

>>> The second patch silences warnings about unused -g, -emit-llvm or -w
>>> flags when linking, similar to the fix that was done for Linux in PR
>>> 8611.  It also corrects a pasto in the comment in
>>> linuxtools::Link::ConstructJob() about this.
>>
>> Would be nice to factor this some day, but LGTM.
>
> Yes, there could be lots of refactoring in Tools.cpp. :)  I have a number
> of other minor cosmetic cleanups in the FreeBSD-specific parts, but I'm
> reluctant to touch (and possibly wreck) any other OS...
>

I understand.

Cheers,
Rafael