[cfe-commits] r160634 - in /cfe/trunk: include/clang/AST/CommentSema.h lib/AST/CommentSema.cpp

[Jordan Rose]

On Jul 24, 2012, at 13:59 , Dmitri Gribenko <gribozavr at gmail.com> wrote:

> Hi Jordan!
> 
> Thank you for the review!
> 
> On Mon, Jul 23, 2012 at 11:27 AM, Jordan Rose <jordan_rose at apple.com> wrote:
>> But more importantly, I don't see where IsThisDeclInspected gets reset to
>> false.
> 
> In the member initializer list:
> 
> Sema::Sema(llvm::BumpPtrAllocator &Allocator, const SourceManager &SourceMgr,
>            DiagnosticsEngine &Diags) :
> -    Allocator(Allocator), SourceMgr(SourceMgr), Diags(Diags), ThisDecl(NULL) {
> +    Allocator(Allocator), SourceMgr(SourceMgr), Diags(Diags), ThisDecl(NULL),
> +    IsThisDeclInspected(false) {
> }
> 

That's where it's initially set to false. I'll admit I haven't tracked the comment framework so closely, but surely you don't recreate the comment::Sema object for every Decl? Then again, I do see "ThisDecl"...