[cfe-commits] Refactor thread safety attribute sema checks

[Delesley Hutchins]

There are a lot of style violations related to indentation.  In particular:

* Function bodies should be indented 2 spaces.  Many of yours are 4 spaces.
* Function arguments should line up when wrapped to the next line.
* Make sure lines don't go over the 80-column limit.

Other than that, looks fine.  Thanks for the refactor!

  -DeLesley

On Fri, Jul 20, 2012 at 9:55 PM, Michael Han <Michael.Han at autodesk.com> wrote:
> Hi,
>
>
>
> Attached patch refactors the semantic check of some thread safety attributes
> which share same semantic check function that uses a bool parameter to turn
> on / off different checks for different attributes. This patch removes the
> bool parameter from the functions by extracting common checks and providing
> a dedicated check function for each thread safety attribute.
>
>
>
> This will make the code easier to read and make the semantic handlers
> consistent across all attributes so we can automate some of the checks
> through tblgen (which I plan to do in next patch).
>
>
>
> Please review thanks!
>
>
>
> Michael
>
>
>
>



-- 
DeLesley Hutchins | Software Engineer | delesley at google.com | 505-206-0315