[cfe-commits] Refactor thread safety attribute sema checks

Michael Han Michael.Han at autodesk.com
Fri Jul 20 21:55:08 PDT 2012


Hi,

Attached patch refactors the semantic check of some thread safety attributes which share same semantic check function that uses a bool parameter to turn on / off different checks for different attributes. This patch removes the bool parameter from the functions by extracting common checks and providing a dedicated check function for each thread safety attribute.

This will make the code easier to read and make the semantic handlers consistent across all attributes so we can automate some of the checks through tblgen (which I plan to do in next patch).

Please review thanks!

Michael


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120721/9b5b8f1e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SemaAttr.patch
Type: application/octet-stream
Size: 18616 bytes
Desc: SemaAttr.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120721/9b5b8f1e/attachment.obj>


More information about the cfe-commits mailing list