[cfe-commits] [Patch] -Wduplicate-enum which fixes PR6343

[Ted Kremenek]

On Jul 18, 2012, at 6:34 PM, Richard Trieu <rtrieu at google.com> wrote:

> A set could work for detecting the values, but both EnumConstantDecls are needed for the diagnostic, not just the values.  Possibly a map from APSInt->EnumConstantDecl* would work.  But either way, I would be dealing with getting APSInts to play nice with each other.

That seems reasonable to me.  The primary performance issue I see is the quadratic algorithmic complexity.  If the APSInt comparisons are an issue, we can see if we can find ways to optimize that further.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120718/409e451b/attachment.html>