[cfe-commits] [PATCH] Fix random crasher

[Robinson, Paul]

Guard use of a possibly uninitialized field.

This was causing very unpredictable compiler crashes. I have not
provided a test because even our most reliable reproducer still failed
less than 10% of the time.

I really really really don't like sometimes-uninitialized fields
guarded by flags. It is not a robust practice and took us a couple of
weeks of poking at it to find the root cause. But it is how the rest
of SemaOverload handles this field, so we fixed it using the
prevailing practice in the module.
--paulr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crash-fix.diff
Type: application/octet-stream
Size: 600 bytes
Desc: crash-fix.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120718/94b2f4b9/attachment.obj>