[cfe-commits] r160308 - in /cfe/trunk: lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CodeGenFunction.h test/CodeGen/builtins-mips-ovld.c

[Benjamin Kramer]

On 16.07.2012, at 21:32, Simon Atanasyan <satanasyan at mips.com> wrote:

> On Mon, Jul 16, 2012 at 11:01 PM, Benjamin Kramer <benny.kra at gmail.com> wrote:
>> On 16.07.2012, at 20:52, Simon Atanasyan <satanasyan at mips.com> wrote:
>>> Author: atanasyan
>>> Date: Mon Jul 16 13:52:02 2012
>>> New Revision: 160308
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=160308&view=rev
>>> Log:
>>> MIPS: Implement __builtin_mips_shll_qb builtin function overloading.
>>> This function has two versions. The first one is used for a register operand.
>>> The second one is used for an immediate number.
>> 
>> Would it make sense to do this as an optimization in the backend instead? The IR optimizers can infer constants in a lot more cases, I assume the constant version of the builtin only differs in performance/code size?
> 
> Akira, is it possible to select an appropriate builtin in the MIPS
> backend? In other words is it acceptable if the frontend emits a
> single builtin nevertheless the function's arguments and the backend
> is responsible for selecting and appropriate intrinsics?
> 
> BTW Benjamin, if I send a patch for review and do not get any
> objections, is it okay to commit this patch in a week? Should I
> continue to ping until I get any reply?

In general it is not okay to just commit things when there are no replies.
I know how annoying this can be, and there are people working on
getting a better process for reviews for llvm and clang eventually.

For patches that don't touch other targets and contain test cases, like
this one, I'd suggest getting review from your mips peers, they
know the target best.

I admit that I screwed this one up, I wanted to comment on your patch
earlier but forgot about it. If you know someone who has worked in the
specific code area recently, feel free to ping them in person. Most of
us are busy enough in their daily routine so things get lost in the noise
of cfe-commits but we won't be mad if reminded.

- Ben