[cfe-commits] Patch for review: Parenthesis range in CXXConstructExprs

[Richard Smith]

On Tue, Jul 10, 2012 at 10:33 PM, Daniel Jasper <djasper at google.com> wrote:

> Ok. So we'll definitely need to do some work on this. Getting back to this
> patch: I still think it sort of cannot be wrong, as the CXXConstructExpr
> currently has the ParenRange and this patch leads to it being correctly
> populated. Do you mind getting it in or do you think it makes the current
> inconsistent situation worse?


Sorry for the delay. I agree that, if we have a ParenRange on
CXXConstructExpr, it should be correct. Patch LGTM for that. Long-term, I
think we'll want to remove this member and follow John's direction of a
CXXDirectInitExpr, but for now this seems better than the status quo.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120716/8aacb0e7/attachment.html>