[cfe-commits] r160034 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/CodeGenCXX/visibility.cpp

[John McCall]

On Jul 11, 2012, at 6:30 AM, Rafael Espíndola wrote:
>> In that case, I don't think you need any of these checks there
>> except, maybe, isa<CXXRecordDecl>(CurContext);  I believe
>> ActOnTagFinishDefinition is called exclusively by the parser.
>> 
>> Hmm.  I tend to think that this pragma should also apply to enum
>> definitions within its scope.  Is that not what GCC does?
> 
> It looks like gcc ignores visibility attributes in enums completely.
> We already accept it with explicit attributes, so I think we should
> accept it with pragmas too or drop the support for it. In any case,
> this part of the code should handle tags uniformly.
> 
> <t.patch>

Looks good, thanks!

John.