[cfe-commits] r160034 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/CodeGenCXX/visibility.cpp
Rafael Espindola
rafael.espindola at gmail.com
Tue Jul 10 19:15:51 PDT 2012
Author: rafael
Date: Tue Jul 10 21:15:51 2012
New Revision: 160034
URL: http://llvm.org/viewvc/llvm-project?rev=160034&view=rev
Log:
Don't process #pragma visibility during instantiation. The visibility of the
instantiation depends on the template, its arguments and parameters, but not
where it is instantiated.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/test/CodeGenCXX/visibility.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=160034&r1=160033&r2=160034&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaDecl.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDecl.cpp Tue Jul 10 21:15:51 2012
@@ -10062,7 +10062,8 @@
// If there's a #pragma GCC visibility in scope, and this isn't a subclass,
// set the visibility of this record.
- if (Record && !Record->getDeclContext()->isRecord())
+ if (Record && !Record->getDeclContext()->isRecord() &&
+ !isa<ClassTemplateSpecializationDecl>(Record))
AddPushedVisibilityAttribute(Record);
}
Modified: cfe/trunk/test/CodeGenCXX/visibility.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/visibility.cpp?rev=160034&r1=160033&r2=160034&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenCXX/visibility.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/visibility.cpp Tue Jul 10 21:15:51 2012
@@ -974,3 +974,16 @@
// CHECK: define internal void @_ZN6test523zedILPNS_12_GLOBAL__N_13fooE0EEEvv
// CHECK-HIDDEN: define internal void @_ZN6test523zedILPNS_12_GLOBAL__N_13fooE0EEEvv
}
+
+namespace test53 {
+ template<typename _Tp > struct vector {
+ static void _M_fill_insert();
+ };
+#pragma GCC visibility push(hidden)
+ void foo() {
+ vector<unsigned>::_M_fill_insert();
+ }
+#pragma GCC visibility pop
+ // CHECK: declare void @_ZN6test536vectorIjE14_M_fill_insertEv
+ // CHECK-HIDDEN: declare void @_ZN6test536vectorIjE14_M_fill_insertEv
+}
More information about the cfe-commits
mailing list