[cfe-commits] r159997 - in /cfe/trunk: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp

[Richard Smith]

On Tue, Jul 10, 2012 at 9:50 AM, Axel Naumann <Axel.Naumann at cern.ch> wrote:

> Author: axel
> Date: Tue Jul 10 11:50:27 2012
> New Revision: 159997
>
> URL: http://llvm.org/viewvc/llvm-project?rev=159997&view=rev
> Log:
> Improve r159256 following Chandler's comments:
> Implement UniqueFileContainer::erase(), camelCase, add comment on future
> optimizations of the cache versus de-optimizations of invalidations.
>
[...]

> @@ -112,7 +112,7 @@
>
>    size_t size() const { return UniqueFiles.size(); }
>
> -  friend class FileManager;
> +  void erase(const FileEntry *Entry) {
> UniqueFiles.erase(Entry->getName()); }
>

(In the LLVM_ON_WIN32 case...) This is wrong. The key in the UniqueFiles
map isn't Entry->getName(); see UniqueFileContainer::getFile.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120710/e71210d1/attachment.html>