[cfe-commits] PATCH: Inline storage of attributes in AttributedStmt

Richard Smith richard at metafoo.co.uk
Sun Jul 8 21:24:14 PDT 2012

A couple of things:
* AttributedStmt::CreateEmpty isn't allocating enough space for the Attr*s.
* Please capitalize the parameters to the AttributedStmt member functions.

LGTM with those fixed.

On Fri, Jul 6, 2012 at 3:24 AM, Alexander Kornienko <alexfh at google.com>wrote:

> Did anyone have time to look at this?
> On Thu, Jul 5, 2012 at 9:42 PM, Alexander Kornienko <alexfh at google.com>wrote:
>> Hi,
>> This patch changes AttrVec to inline storage of attributes in
>> AttributedStmt. I also had to add a template parameter for container type
>> to specific_attr_iterator to make it handle ArrayRef along with AttrVec.
>> Updated serialization code, but there's still no good way to test it.
>> Please take a look at this patch.
>> --
>> Regards,
>> Alexander Kornienko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120708/0b16ccb7/attachment.html>

More information about the cfe-commits mailing list