[cfe-commits] r159875 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Driver/Options.td lib/Driver/Tools.cpp lib/Frontend/TextDiagnosticPrinter.cpp test/Driver/warning-options.cpp test/Misc/show-diag-options.c test/Misc/warning-flags.c tools/libclang/CXStoredDiagnostic.cpp utils/TableGen/ClangDiagnosticsEmitter.cpp

[John McCall]

On Jul 6, 2012, at 4:07 PM, Ted Kremenek wrote:
> Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp?rev=159875&r1=159874&r2=159875&view=diff
> ==============================================================================
> --- cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp (original)
> +++ cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp Fri Jul  6 18:07:31 2012
> +class InferPedantic {
> +  typedef llvm::DenseMap<const Record*,
> +                         std::pair<unsigned, llvm::Optional<unsigned> > > GMap;
> +
> +  DiagGroupParentMap &DiagGroupParents;
> +  const std::vector<Record*> &Diags;

ArrayRef?

> +  const std::vector<Record*> DiagGroups;

Missing a &, but probably should also be an ArrayRef.

> +  std::map<std::string, GroupInfo> &DiagsInGroup;

StringMap?

> +  /// Determine whether a group is a subgroup of another group.
> +  bool isSubGroupOfGroup(const Record *Group,
> +                         llvm::StringRef RootGroupName);
> +
> +  /// Determine if the diagnostic is an extension.
> +  bool isExtension(const Record *Diag);
> +
> +  /// Increment the count for a group, and transitively marked
> +  /// parent groups when appropriate.
> +  void markGroup(const Record *Group);
> +
> +  /// Return true if the diagnostic is in a pedantic group.
> +  bool groupInPedantic(const Record *Group, bool increment = false);

Conventionally, this should be isGroupInPedantic.

> +/// Determine if the diagnostic is an extension.
> +bool InferPedantic::isExtension(const Record *Diag) {
> +  const std::string &ClsName = Diag->getValueAsDef("Class")->getName();
> +  return ClsName == "CLASS_EXTENSION";
> +}

Not also EXTWARN?

> +  // Consider a group in -Wpendatic IFF if has at least one diagnostic

Typo: -Wpedantic

> -    
> +    const bool IsPedantic = I->first == "pedantic";

We don't usually make locals const.

Otherwise, we had a discussion about how -Wpedantic should interact with
-pedantic.  For the public record, Ted's going to make sure that things like
-Wno-pedantic -pedantic (at the driver level) leaves all the pedantic warnings
on.

John.