[cfe-commits] r159875 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Driver/Options.td lib/Driver/Tools.cpp lib/Frontend/TextDiagnosticPrinter.cpp test/Driver/warning-options.cpp test/Misc/show-diag-options.c test/Misc/war

[Richard Smith]

On Fri, Jul 6, 2012 at 4:12 PM, Jordan Rose <jordan_rose at apple.com> wrote:

>
> On Jul 6, 2012, at 16:07 , Ted Kremenek <kremenek at apple.com> wrote:
>
> > This patch also significantly reduces the number of warnings not under
> flags from 229
> > to 158 (all extension warnings).  That's a 31% reduction.
>
> …but it's arguable whether that really counts, since it's likely many of
> these warnings should have actual flags anyway…
>

... and indeed we no longer have any protection against extension warnings
being added with no explicit flag (other than -Wpedantic, which doesn't
seem fine-grained enough to be useful). Would it be worthwhile to teach
diagtool to additionally list diagnostics which are contained directly in
the 'pedantic' group and include that in our CHECKs, with the intention of
eventually emptying that list too?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120706/0ee326a6/attachment.html>