[cfe-commits] [Patch 1 of 7] -verify fixes and enhancement

Jordan Rose jordan_rose at apple.com
Tue Jul 3 17:32:31 PDT 2012

On Jul 3, 2012, at 3:22 PM, Andy Gibbs wrote:

> On Monday, July 02, 2012 6:47 PM, Jordan Rose wrote:
>> I'm reviewing these in order, so I apologize if my comments don't make sense
>> in the larger context.
>> +#include <climits>
>> +    /// Constant representing one or more matches aka regex "+".
>> +    static const unsigned OneOrMoreCount =  UINT_MAX;
>> I assume this'll go away anyway in a later patch (when you allow "2+"), at
>> which point you can drop the #include again. :-)
> It stays but gets renamed (you've probably already seen this but I include this
> here for anyone else following this).  It becomes the maximum number of
> matches possible when you do an "<n>+".  There's no particular issue to
> using <climits> is there?

Other files include it, so I guess not.

> The revised patch is attached.  Should be ready for commit now?

Everything looks good to me, but perhaps wait until at least one of the actual enhancement patches is fully approved, since this one moves implementation to the header file without a corresponding benefit. :-)

More information about the cfe-commits mailing list