[cfe-commits] [Patch 2 of 7] -verify fixes and enhancement

Jordan Rose jordan_rose at apple.com
Tue Jul 3 16:22:33 PDT 2012

On Jul 3, 2012, at 3:23 PM, Andy Gibbs wrote:

>>> I see we do check if the location is invalid; I think it's okay to make
>>> that an assertion. These checks should never come from or refer to lines on
>>> the command line.
> I'm afraid it isn't possible to do an assertion since it is very possible for
> a test-case writer to provide an invalid line number, for example:
> // expected-error@ {{...}}
> // expected-error at 0 {{...}}
> // expected-error at -3 {{...}}
> (the third will be invalid if the line number of the directive is 3 or less).

In that case, I'd still prefer to treat these as errors, with a possible exception of "@0" meaning "(frontend)". "@" and "@-3" (or "@5000" or "@+50000") seem like things we can catch up front.


More information about the cfe-commits mailing list