[cfe-commits] [Patch 3 of 7] -verify fixes and enhancement

Andy Gibbs andyg1001 at hotmail.co.uk
Tue Jul 3 15:23:04 PDT 2012

On Monday, July 02, 2012 8:45 PM, Jordan Rose wrote:
> On Jul 2, 2012, at 11:40 , Andy Gibbs wrote:
>> On Monday, July 02, 2012 7:46 PM, Jordan Rose wrote:
>>> You should describe the new range syntax in the comment in
>>> VerifyDiagnosticConsumer.h, but otherwise LGTM.
>> Silly question: did you notice that I did describe the new syntax?  Is it
>> that you think I didn't explain it clearly enough?
> Whoops, yes. I was expecting to see a line-of-code example for ranges just
> like for "x-or-more" syntax, in the spirit of "a picture is worth a 
> thousand
> words". I just completely missed the single sentence that described the 
> range
> syntax.
> (The "…or more" description was fine.)

Well, I had a few minutes and since I had to rebase the patches anyway, I've
added a fuller description ;o)

Good to commit?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: verify-part3.diff
Type: application/octet-stream
Size: 9369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120704/44821462/attachment.obj>

More information about the cfe-commits mailing list