[cfe-commits] [Patch 7 of 7] -verify fixes and enhancement

[Jordan Rose]

> Index: tools/clang/test/Modules/Inputs/Module.framework/Headers/Module.h
> ==================================================================
> --- tools/clang/test/Modules/Inputs/Module.framework/Headers/Module.h
> +++ tools/clang/test/Modules/Inputs/Module.framework/Headers/Module.h
> @@ -1,6 +1,6 @@
> -// expected-warning{{umbrella header}}
> +// expected-warning 0-1 {{umbrella header}}
> 
> #ifndef MODULE_H
> #define MODULE_H
> const char *getModuleVersion(void);

This does not mean the same thing. Why is it being changed?


In general I think the "referenced here" / "declared here" notes don't need to be moved. Sure, going forward we should be writing them using @line, but I think it's okay to leave existing ones as is. Although I would actually expect there to be many more such notes, so were you already only doing a few of them? How were they being chosen?