[cfe-commits] r159559 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/ include/clang/StaticAnalyzer/Core/PathSensitive/ lib/StaticAnalyzer/Checkers/ lib/StaticAnalyzer/Core/

Jordan Rose jordan_rose at apple.com
Mon Jul 2 13:50:01 PDT 2012

On Jul 2, 2012, at 13:46 , David Blaikie <dblaikie at gmail.com> wrote:

> On Mon, Jul 2, 2012 at 12:28 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>  // FIXME: Remove this once everything is converted to use ObjCMethodCall.
>> -  operator ObjCMessage() const {
>> -    return ObjCMessage(getOriginExpr(), PropE, isSetter());
> This change rendered the PropE member unused & breaks the -Werror
> clang build (due to -Wunused-private-field). I've removed the member
> (& then unused ctor parameter, and then unused local variable at the
> ctor call site) in r159581. Feel free to re-add it & use it in
> whatever way you see fit if this wasn't the right solution.
> Thanks,
> - David

Oops, thanks. Interesting that we didn't have a need for it now. We probably still want it there even if it's currently unused, though, rather than having to go back and add it later when one of our checkers needs it. I'll add an accessor.

More information about the cfe-commits mailing list