[cfe-commits] [OpenCL patch] Optional attributes (controversial)

[Douglas Gregor]

On Jun 28, 2012, at 7:46 AM, Anton Lokhmotov <Anton.Lokhmotov at arm.com> wrote:

> Here's controversial code for supporting the vec_type_hint and endian
> attributes.  Should be applied after [non-controversial].  Thoughts?

DummyTypeExpr is a really too much of a hack here; aside from losing all source information, it duplicates the functionality of OpaqueValueExpr. Please find a way to pass a ParsedTy through AttributeList and parse the argument as a type.

	- Doug


> Thanks,
> Anton.
> 
> [non-controversial] 
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120625/059814.h
> tml
> 
> 
>> -----Original Message-----
>> From: Anton Lokhmotov [mailto:Anton.Lokhmotov at arm.com]
>> Sent: 28 June 2012 15:41
>> To: 'Tanya Lattner'
>> Cc: cfe-commits at cs.uiuc.edu; 'Benyei, Guy'
>> Subject: RE: [OpenCL patch] Optional attributes (non-controversial)
>> 
>> Hi Tanya,
>> 
>> I've followed your advice and separated code for the work group size
>> attributes (attached) and the other attributes (to be submitted
>> shortly).  Please review.
>> 
>> Best wishes,
>> Anton.
>> 
>> 
>>> -----Original Message-----
>>> From: Tanya Lattner [mailto:lattner at apple.com]
>>> Sent: 23 June 2012 00:35
>>> To: Anton Lokhmotov
>>> Cc: cfe-commits at cs.uiuc.edu; 'Benyei, Guy'
>>> Subject: Re: [OpenCL patch] Optional attributes
>>> 
>>> Anton,
>>> 
>>> I think it may be beneficial to separate out the DummyTypeExpr part
>>> from this patch and have it reviewed separately. Its the only really
>>> concerning part from this patch if I remember right.
>>> 
>>> -Tanya
>>> 
>>> On Jun 14, 2012, at 4:06 PM, Anton Lokhmotov
>> <Anton.Lokhmotov at arm.com>
>>> wrote:
>>> 
>>>> I would like to return to optional attributes [1].  Here's an
>> update
>>> with
>>>> better error handling and tests.  Can be a good starting point to
>>> resume
>>>> resolving [2].  Please review.
>>>> 
>>>> Many thanks,
>>>> Anton.
>>>> 
>>>> [1] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-
>>> January/019448.html
>>>> [2] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-
>>> January/019611.html<attributes.patch>
> <attributes1.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits