[cfe-commits] [PATCH] libclang support for CompilationDatabase + python binding

[Ted Kremenek]

I think the CompilationDatabase feature would be a great addition to libclang.  As you suggest, factoring out Index.h into separate header files (with Index.h including them for backwards compatibility) and having a new one for Tooling support sounds reasonable to me.

Sent from my iPad

On Jun 26, 2012, at 2:53 AM, Arnaud de Grandmaison <arnaud.allarddegrandmaison at parrot.com> wrote:

> Ping
> 
> CC Doug per Chandler's suggestion on irc.
> 
> Basically, the question is : how do we want to handle the Tooling stuff
> with libclang ?
> Should it be part of Index.h ? Should it even be part of libclang ?
> 
> For now, my patch assumes this is completely part of libclang.
> 
> My feeling is it should at least be logically separated, with its own
> header files, with some splitting of Index.h to expose some components
> (like CXString) without the complete Index.h.
> 
> Any directions ?
> 
> Cheers,
> --
> 
> Arnaud de Grandmaison
> 
> 
> 
> On 06/22/2012 02:48 PM, Arnaud de Grandmaison wrote:
>> Attached are 2 patches :
>> - 0001-cindex-cdb.patch : adds support for CompilationDatabase to libclang
>> - 0002-cindex-cdb-python.patch : teaches the python binding to use the
>> functionality added by the first patch
>> 
>> Those 2 patches have already been reviewed by Manuel Klimek and Gregory
>> Szorc, for the C / C++ / python parts.
>> 
>> The only point left is regarding the location of the code, as the first
>> patch adds some functionality which is orthogonal to cindex. Should it
>> live within cindex (as it is in the patch) or should we separate it ?
>> Can someone knowledgeable with the libclang requirements have a look at it ?
>> 
>> Cheers,
>> 
> 
> 
> -- 
> Arnaud de Grandmaison
> 
> <0001-cindex-cdb.patch>
> <0002-cindex-cdb-python.patch>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits