[cfe-commits] [PATCH] OpenCL Kernel arg info metadata

[Tanya Lattner]

Guy,

Personally, I don't think its that useful and would just add some bloat to the metadata. Either way you have to sift through until you find which info you are looking for.

-Tanya

On Jun 26, 2012, at 5:39 AM, "Benyei, Guy" <guy.benyei at intel.com> wrote:

> Hi Tanya,
> The patch looks good, but I wondered if we should separate all the -cl-kernel-arg-info related metadata somehow from the rest of the kernel metadata, something like:
> 
> !1 = metadata !{metadata !"kernel_arg_info", metadata !2, metadata !3,...
> !2 = metadata !{metadata !"kernel_arg_name", metadata !"X", metadata !"Y", metadata !"anotherArg"}
> !3 = metadata !{metadata !"kernel_arg_type_qualifier", i32 0, i32 0, i32 3}
> 
> 
> Thanks
>    Guy
> 
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Tanya Lattner
> Sent: Tuesday, June 26, 2012 02:00
> To: cfe-commits at cs.uiuc.edu
> Subject: [cfe-commits] [PATCH] OpenCL Kernel arg info metadata
> 
> Attached is a patch that implements the OpenCL kernel arg info option (cl-kernel-arg-info) and during code generation it outputs metadata for kernel arguments. In order to have incremental changes, this only adds the kernel arg names to the metadata. The format of the metadata matches the criteria that was discussed early on the mailing list in the form of lists where the first is the  "name"  of the type of metadata and N number of Values. This allows for easy extension in the future and other OpenCL implementations to do their own thing. More info in the comments.
> 
> I've included a test case.
> 
> Please review.
> 
> -Tanya
> 
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>