[cfe-commits] [patch] Added a suggestion when a std::string is passed to printf()

Richard Smith richard at metafoo.co.uk
Mon Jun 25 13:32:37 PDT 2012


Checked in with fix as r159159.

On Fri, Jun 22, 2012 at 5:00 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Fri, Jun 22, 2012 at 4:57 PM, Matt Beaumont-Gay <matthewbg at google.com>wrote:
>
>> On Fri, Jun 22, 2012 at 4:51 PM, Chandler Carruth <chandlerc at google.com>
>> wrote:
>> > On Fri, Jun 22, 2012 at 4:21 PM, Sam Panzer <panzer at google.com> wrote:
>> >>
>> >> This has been fixed in the attached patch, which will look nearly
>> >> identical as the only change was to move a return statement out of one
>> >> enclosing if-else block.
>> >
>> >
>> > Did you add a test case to cover this case?
>>
>> Rafael added a test case when he reverted the original.
>>
>
> Lovely! =D
>
>
>>
>> -Matt
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120625/31c969bf/attachment.html>


More information about the cfe-commits mailing list