[cfe-commits] [PATCH] Warn about almost-Doxygen trailing comments

[Dmitri Gribenko]

On Fri, Jun 22, 2012 at 8:23 AM, Douglas Gregor <dgregor at apple.com> wrote:
> LGTM!

Thank you, committed in r159001.

> On Jun 21, 2012, at 5:01 PM, Dmitri Gribenko wrote:
>
>> On Wed, Jun 20, 2012 at 1:53 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>>> Hello,
>>>
>>> It seems to be common to forget to put extra star (/**<) or slash
>>> (///<) in Doxygen trailing comments.  The attached patch warns in
>>> these cases:
>>>
>>> +struct a {
>>> +  int x; //< comment // expected-warning {{not a Doxygen member comment}}
>>> +  int y; /*< comment */ // expected-warning {{not a Doxygen member comment}}
>>> +};
>>>
>>> Please review.
>>>
>>> I have fixed a few of these in LLVM and Clang manually a while ago. [1] [2]
>>>
>>> [1] http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120604/058729.html
>>> [2] http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120604/144316.html
>>
>> Ping.
>>
>> --
>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>> <warn-almost-doxygen-trailing-comment.patch>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/