[cfe-commits] PATCH: Better support for -g options in Clang driver

[Alexey Samsonov]

On Thu, Jun 21, 2012 at 5:07 AM, Eric Christopher <echristo at apple.com>wrote:

>
> On Jun 20, 2012, at 12:36 AM, Alexey Samsonov wrote:
>
> Ok, I finally returned to this.
>
> On Mon, Jun 4, 2012 at 9:49 PM, Eric Christopher <echristo at apple.com>wrote:
>
>> > ld actually vote no warning at all on levels that don't mean anything...
>> >
>> > Having -g1 and -g3 be implemented the same as -g2 seems like a QoI
>> issue to me. We can always improve this later, or pay attention to these
>> signals if useful later, but it seems weird to warn the user about it...
>>
>
> Fine then. Let's emit the same debug info at levels: 1-3 and output
> nothing at level 0, w/o producing any warnings.
>
> g1 is fairly similar to the work on line tables for what it's worth...
>>
>
>
> Maybe. We don't describe extern variables and do produce line numbers,
> though.
>
>
> Fair enough. I'm not in any rush to support obscure options :)
>
>
>
>> And sure. I don't mind either way. Less warnings are fine.
>>
>>
> Code review: http://codereview.appspot.com/6250082/
>
> --
> Alexey Samsonov, MSK
>
>  <g_options3.diff>
>
>
> Looks fine.
>

r158906, thanks!

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120621/219f602d/attachment.html>