[cfe-commits] [PATCH] Structured comment parsing, retaining comments in AST

[Dmitri Gribenko]

On Tue, Jun 19, 2012 at 5:03 PM, Douglas Gregor <dgregor at apple.com> wrote:
> Unfortunately, this perfectly valid C++ code:
>
> +
> +  CommentKind Kind : 3;
> +
>
> will break MSVC in horrible ways. Please use "unsigned Kind : 3;" here, and add casts where needed.

Oh... fixed.

> The second sentence here should have been added to clang_Cursor_getCommentRange, right?

Right, done.

>> * "After member comment" sounds awkward (but that's how it is called
>> once in Doxygen manual).  Maybe "trailing comment" is better?
>
> Yes, I like "trailing comment" better.

Renamed everything that read "after member" to "trailing comment".

> This looks great! Please go ahead and commit.

Committed r158771.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/