[cfe-commits] MS name mangling improvements

[João Matos]

Thanks for the review.

> Per the coding conventions, this should be named BackReferences (and
> likewise for other variable and field declarations in the patch).

Done.

> This will do different things depending on the order in which the
> arguments to operator= are evaluated.

I changed it to get the size in a different statement.

> It looks like this will include cv-qualifiers on function parameter
> types in the mangled name. That can't be right, since they're not part
> of the function type. I suspect you should drop the uses of
> getTypeSourceInfo() here. (This bug seems to predate your change).

Well I tried dropping it, but it is needed for arrays, tests were
failing without it.

> We use 'cxx11' not 'cpp11' in the tests/ area to refer to C++11.

Renamed.

I also added a fix in the new patch for bug #12603
(http://llvm.org/bugs/show_bug.cgi?id=12603).

-- 
João Matos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-MicrosoftMangling.patch
Type: application/octet-stream
Size: 7197 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120619/e8b41e6d/attachment.obj>