[cfe-commits] [PATCH] Automatically handle parsing of attribute namespaces.

[Sean Hunt]

On Fri, Jun 15, 2012 at 2:37 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> Hi Sean,
>
> On Fri, Jun 15, 2012 at 2:07 PM, Sean Hunt <scshunt at csclub.uwaterloo.ca> wrote:
>> On the basis that the code should be self-descriptive, no description.
>
> Is the diff missing part of the patch sequence?
>
> --- a/lib/Sema/AttributeList.cpp
> +++ b/lib/Sema/AttributeList.cpp
> @@ -109,10 +111,13 @@ AttributeList::Kind AttributeList::getKind(const
> IdentifierInfo *Name,
>       AttrName.size() >= 4)
>     AttrName = AttrName.substr(2, AttrName.size() - 4);
>
> -  // FIXME: implement attribute namespacing correctly.
>   SmallString<64> Buf;
>   if (ScopeName)
> -    (Buf += ScopeName->getName()) += "::";
>
> This doesn't match the code in my checkout.
>

Ah it is, good catch.

Fix attached.

Sean
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attr-namespace.patch
Type: application/octet-stream
Size: 19292 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120615/80f68963/attachment.obj>