[cfe-commits] [PATCH] Abstract v-table generation into the CGCXXABI interface

Charles Davis cdavis at mymail.mines.edu
Fri Jun 15 11:49:46 PDT 2012


Hi,

This patch factors v-table generation into the CGCXXABI class, so that, in the future, the Microsoft C++ ABI can implement its own v-table generation.

I also had to move the ItaniumCXXABI class into a header, so that CGRTTI could continue to use the getVTableLinkage() method, which now lives in ItaniumCXXABI. I thought that since CGRTTI is specific to the Itanium ABI anyway, this was OK. I don't know if you would prefer that method continue to belong to CodeGenModule, but I imagine that the Microsoft C++ ABI may have different rules for v-table visibility (which I have yet to work out).

OK to commit?

Chip
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cxx-abi-vtable-gen-1.patch
Type: application/octet-stream
Size: 16807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120615/c827375a/attachment.obj>


More information about the cfe-commits mailing list