[cfe-commits] [PATCH] Explicitly Build __builtin_va_list

[Meador Inge]

On 06/15/2012 01:05 PM, Dmitri Gribenko wrote:

> On Tue, Jun 12, 2012 at 9:29 PM, Inge, Meador <meador_inge at mentor.com> wrote:
>> Hi All,
>>
>> As discussed here [1], I have been working on a patch to explicitly build the target specific __builtin_va_list type instead of just injecting a string into the preprocessor input.  This will provide a cleaner separation between preprocessor input and builtin types, will allow us to remove the special casing in 'Sema::ActOnTypedefNameDecl' to notify the AST context of __builtin_va_list, and will allow us to remove the extra tracking added for PR 12665 in r158085.
>>
>> OK to commit?  If this is accepted, I will go backout the tracking portions of r158085 in another commit.
> 
> I don't think it is a good idea to renumber enums in ASTBitCodes.h.

Can you elaborate?  If it because this is a breaking compatibility change, I
raised this issue already [1] and it was deemed acceptable to break
compatibility.

[1] http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120604/058617.html

-- 
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software