[cfe-commits] [patch] rewrite-includes crash support

[David Blaikie]

On Thu, Jun 14, 2012 at 11:08 AM, Chandler Carruth <chandlerc at google.com> wrote:
> The driver support for rewrite includes LGTM, commit away.

r158463

> Regarding the crash reporting, that looks too easy! ;]

It does, doesn't it...

> Does anything need to be changed in the reproduction script to make it use the include-rewritten
> file instead of a fully preprocessed file?

Ah, I hadn't actually tried the repro script file - I tend to just run
the crashers myself (but of course then I don't get the extra flags,
etc, from the repro).

The script is generated based on the file name reported as the output
file by the compilation command, as I understand/read it - so it's not
referring to a non-existent file (& the file name remains the same in
any case).

>  Do we need to change the filename?

It seems to work fine (reckon it'd be appropriate to have a test case
for this that actually executes the crash report script file? that
seems a little nasty, but with some value). The -cc1 command includes
an explicit -x so I don't think there's any file extension based
language detection (so it doesn't try to skip preprocessing, for
example).

- David