[cfe-commits] [PATCH] OpenCL inline calls have internal linkage

[John McCall]

On Jun 14, 2012, at 4:15 AM, Anton Lokhmotov wrote:
>> In OpenCL inline calls without a specified storage class should have
>> internal linkage. The attached patch makes this modification and adds a
>> test case.
> 
> If this is OpenCL 1.2 specific, it should be guarded on a new language
> option OpenCL_1_2 [1].
> 
> +
> +// CHECK: define internal fastcc i32 @bar(i32 %X) nounwind readnone
> inlinehint
> +
> 
> Please correct me if I'm wrong but isn't fastcc an x86-specific calling
> convention?  In this case, a regular expression should be used to allow this
> check passing on a different architecture.

You're thinking of 'fastcall', which is spelled 'x86_fastcall'.  'fastcc' is
an LLVM abstraction which intentionally does not provide any ABI
constraints.

John.