[cfe-commits] [patch] rewrite-includes crash support

[Chandler Carruth]

On Wed, Jun 13, 2012 at 4:57 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Sending this for review because it has a few different changes in
> areas I'm less familiar with (driver) though they're mostly
> mechanical. Each one's probably OK for post-commit review, but I
> didn't want to spam the commit queue & then find review feedback for
> the first one that would interfere with the later patches & all get a
> bit messy.
>

Can you break these up into separate patches to make review easier?


> The changes included are:
>
> Rename -rewrite-includes to -frewrite-includes
>

Just commit this part, it's fine to post-commit review.


> Support -frewrite-includes as an option while preprocessing, rather
> than as a flag of its own
>

Go ahead and commit this one too, although a separate commit please.


> Fix crash in -frewrite-includes when a #include specified a file that
> could not be found.
>

And go ahead and commit this one, but again as a separate commit. =]


Then lets review the two left as two separate patch files?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120613/4ddf0806/attachment.html>