[cfe-commits] Support Android standalone toolchain in Clang driver

Evgeniy Stepanov eugeni.stepanov at gmail.com
Wed Jun 13 01:10:48 PDT 2012


ping

On Fri, Jun 8, 2012 at 2:03 PM, Evgeniy Stepanov
<eugeni.stepanov at gmail.com> wrote:
> ping
>
> On Mon, Jun 4, 2012 at 7:35 PM, Evgeniy Stepanov
> <eugeni.stepanov at gmail.com> wrote:
>> Oops.
>> Please take another look.
>>
>> On Mon, Jun 4, 2012 at 7:11 PM, Benjamin Kramer
>> <benny.kra at googlemail.com> wrote:
>>>
>>> On 04.06.2012, at 17:00, Evgeniy Stepanov wrote:
>>>
>>>> Hi,
>>>>
>>>> this patch adds detection of C++ headers and libraries paths when
>>>> building with the standalone toolchain from Android NDK. They are in a
>>>> slightly unusual place.
>>>>
>>>> Please review.
>>>
>>>> const Twine IncludePathCandidates[] = {
>>>
>>> You can't store an array of Twines. The class relies on temporary objects which are destroyed at the end of the statement. The compiler can chose to reallocate the memory of the temporary and your code will fail.
>>>
>>> - Ben
>>>> <android-standalone.patch>_______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: android-standalone.patch
Type: application/octet-stream
Size: 7049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120613/fea72911/attachment.obj>


More information about the cfe-commits mailing list