[cfe-commits] Rewriter patch submission

[Manuel Klimek]

I can't comment on the overall strategy for Rewriter, but I've got one more
high level comment:
Rewriter is now easy to unit test (see
tools/clang/unittests/Tooling/RewriterTest.cpp), and I think it would be
nice if we'd add unit tests for changes like this.

Cheers,
/Manuel

On Sun, Jun 10, 2012 at 12:47 AM, Thomas Minor <sxeraverx at gmail.com> wrote:

> Hello,
>
> I would like to submit a patch to the Rewriter. Currently, a delete
> followed by an insert in the same spot isn't treated the same way as a
> replace. This patch fixes this. It also causes the replacement of a
> zero-length segment to be treated the same way as an insertion would be.
>
> All clang unit test suites pass.
>
> Regards,
> Thomas Minor
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120611/c8c57f24/attachment.html>