[cfe-commits] r158112 - /cfe/trunk/unittests/Tooling/RewriterTestContext.h

Benjamin Kramer benny.kra at googlemail.com
Thu Jun 7 02:38:08 PDT 2012


On 07.06.2012, at 09:16, Chandler Carruth <chandlerc at google.com> wrote:

On Wed, Jun 6, 2012 at 11:07 PM, John McCall <rjmccall at apple.com> wrote:

> On Jun 6, 2012, at 2:28 PM, Manuel Klimek wrote:
> > Author: klimek
> > Date: Wed Jun  6 16:28:13 2012
> > New Revision: 158112
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=158112&view=rev
> > Log:
> > Switches the RewriterTestContext away from PathV1.
> > Now the ToolingTests all work on Windows, and they also clean up their
> temporary directory if they don't crash.
>
> It looks like this is causing failures on release builds on darwin:
>
> ******************** TEST 'Clang-Unit ::
> Tooling/Release/ToolingTests/Rewriter.ContinuesOverwritingFilesOnError'
> FAILED
> ********************Note: Google Test filter =
> Rewriter.ContinuesOverwritingFilesOnError
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from Rewriter
> [ RUN      ] Rewriter.ContinuesOverwritingFilesOnError
> LLVM ERROR: IO failure on output stream.
>
> ********************
>
>
> ******************** TEST 'Clang-Unit ::
> Tooling/Release/ToolingTests/Rewriter.OverwritesChangedFiles' FAILED
> ********************Note: Google Test filter =
> Rewriter.OverwritesChangedFiles
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from Rewriter
> [ RUN      ] Rewriter.OverwritesChangedFiles
> LLVM ERROR: IO failure on output stream.
>
> ********************
>
> I know this isn't much to go on, sorry.


Ugh... I don't even know how to dig into this. Manuel is on holiday, so
unless you have any ideas what is causing this, you may need to just
revert...


The call to unique_file is side effecting but wrapped inside assert() and
gets discarded in release builds. I'll fix this.

- Ben

_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120607/e66b5d89/attachment.html>


More information about the cfe-commits mailing list