[cfe-commits] r158054 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/Sema.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaExprMember.cpp test/SemaCXX/warn-unused-member.cpp

[Benjamin Kramer]

On 06.06.2012, at 18:29, Jordan Rose wrote:

> Great! Out of curiosity, did you test how many times this pops up when compiling LLVM/Clang?

I ran it on clang and LLVM and it found a lot of cases. This is something that comes up a lot during refactoring, and really useful to be warned about. I cleaned up most of the cases in LLVM and I think this is a perfect candidate for -Wextra, maybe even -Wall.

- Ben
> 
> 
> On Jun 6, 2012, at 1:32 , Daniel Jasper <djasper at google.com> wrote:
> 
>> Author: djasper
>> Date: Wed Jun  6 03:32:04 2012
>> New Revision: 158054
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=158054&view=rev
>> Log:
>> Introduce -Wunused-private-field. If enabled, this warning detects
>> unused private fields of classes that are fully defined in the current
>> translation unit.
>> 
>> Added:
>>   cfe/trunk/test/SemaCXX/warn-unused-member.cpp
>> Modified:
>>   cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>>   cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>>   cfe/trunk/include/clang/Sema/Sema.h
>>   cfe/trunk/lib/Sema/Sema.cpp
>>   cfe/trunk/lib/Sema/SemaDeclCXX.cpp
>>   cfe/trunk/lib/Sema/SemaExprMember.cpp
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits