[cfe-commits] Clang change to detect and warn about unused private members

Jordan Rose jordan_rose at apple.com
Tue Jun 5 16:32:00 PDT 2012


Oops! The original intent of the test-on-add was to avoid doing work when the diagnostic is ignored. But it might as well avoid doing work when the diagnostic is /temporarily/ ignored, i.e. using pragmas. Please change the test in ActOnCXXMemberDeclarator to actually use the FieldDecl's SourceLocation.

With that and the braces Richard caught in IsRecordFullyDefined, it can go in. Thanks, Daniel!

Jordan




More information about the cfe-commits mailing list