[cfe-commits] r157946 - in /cfe/trunk: lib/Sema/SemaExprObjC.cpp test/SemaObjC/weak-receiver-warn.m
Fariborz Jahanian
fjahanian at apple.com
Mon Jun 4 12:16:34 PDT 2012
Author: fjahanian
Date: Mon Jun 4 14:16:34 2012
New Revision: 157946
URL: http://llvm.org/viewvc/llvm-project?rev=157946&view=rev
Log:
objective-c: Handle more warning cases for when
message receiver is 'weak' property.
// rdar://10225276
Modified:
cfe/trunk/lib/Sema/SemaExprObjC.cpp
cfe/trunk/test/SemaObjC/weak-receiver-warn.m
Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprObjC.cpp?rev=157946&r1=157945&r2=157946&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExprObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprObjC.cpp Mon Jun 4 14:16:34 2012
@@ -1347,6 +1347,9 @@
if (!Receiver)
return;
+ if (OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(Receiver))
+ Receiver = OVE->getSourceExpr();
+
Expr *RExpr = Receiver->IgnoreParenImpCasts();
SourceLocation Loc = RExpr->getLocStart();
QualType T = RExpr->getType();
@@ -1369,6 +1372,20 @@
}
}
}
+ else if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(RExpr)) {
+ // See if receiver is a method which envokes a synthesized getter
+ // backing a 'weak' property.
+ ObjCMethodDecl *Method = ME->getMethodDecl();
+ if (Method && Method->isSynthesized()) {
+ Selector Sel = Method->getSelector();
+ if (Sel.getNumArgs() == 0)
+ PDecl =
+ S.LookupPropertyDecl(Method->getClassInterface(),
+ Sel.getIdentifierInfoForSlot(0));
+ if (PDecl)
+ T = PDecl->getType();
+ }
+ }
if (T.getObjCLifetime() == Qualifiers::OCL_Weak) {
S.Diag(Loc, diag::warn_receiver_is_weak)
Modified: cfe/trunk/test/SemaObjC/weak-receiver-warn.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/weak-receiver-warn.m?rev=157946&r1=157945&r2=157946&view=diff
==============================================================================
--- cfe/trunk/test/SemaObjC/weak-receiver-warn.m (original)
+++ cfe/trunk/test/SemaObjC/weak-receiver-warn.m Mon Jun 4 14:16:34 2012
@@ -15,7 +15,7 @@
[weakx addBlock: ^{ [x actNow]; }]; // expected-warning {{weak receiver may be unpredictably null in ARC mode}}
[weakx setBlock: ^{ [x actNow]; }]; // expected-warning {{weak receiver may be unpredictably null in ARC mode}}
- weakx.block = ^{ [x actNow]; };
+ weakx.block = ^{ [x actNow]; }; // expected-warning {{weak receiver may be unpredictably null in ARC mode}}
}
@interface Test
@@ -48,3 +48,21 @@
@dynamic weak_prop, weak_atomic_prop;
@end
+
+ at interface MyClass {
+ __weak MyClass *_parent;
+}
+ at property (weak) MyClass *parent; // expected-note 2 {{property declared here}}
+ at end
+
+ at implementation MyClass
+ at synthesize parent = _parent;
+
+- (void)doSomething
+{
+ [[self parent] doSomething]; // expected-warning {{weak property may be unpredictably null in ARC mode}}
+
+ (void)self.parent.doSomething; // expected-warning {{weak property may be unpredictably null in ARC mode}}
+}
+
+ at end
More information about the cfe-commits
mailing list