[cfe-commits] r157890 - /cfe/trunk/unittests/Tooling/ToolingTest.cpp

[Hal Finkel]

On Sat, 02 Jun 2012 15:34:27 -0000
NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Author: chapuni
> Date: Sat Jun  2 10:34:26 2012
> New Revision: 157890
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=157890&view=rev
> Log:
> Revert r157819, "#ifdef out a broken test on win32"
> 
> FYI, LLVM_ON_WIN32 is useless.

Can you be more specific? I thought that configure defined these (and I
assumed that the other build systems did too as appropriate). Is that
not true?

 -Hal

> 
> Modified:
>     cfe/trunk/unittests/Tooling/ToolingTest.cpp
> 
> Modified: cfe/trunk/unittests/Tooling/ToolingTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/ToolingTest.cpp?rev=157890&r1=157889&r2=157890&view=diff
> ==============================================================================
> --- cfe/trunk/unittests/Tooling/ToolingTest.cpp (original) +++
> cfe/trunk/unittests/Tooling/ToolingTest.cpp Sat Jun  2 10:34:26 2012
> @@ -110,9 +110,6 @@ EXPECT_TRUE(Action.get() != NULL);
>  }
>  
> -#ifndef LLVM_ON_WIN32
> -// This test breaks on Windows.
> -
>  TEST(ToolInvocation, TestMapVirtualFile) {
>    clang::FileManager Files((clang::FileSystemOptions()));
>    std::vector<std::string> Args;
> @@ -126,7 +123,5 @@
>    EXPECT_TRUE(Invocation.run());
>  }
>  
> -#endif
> -
>  } // end namespace tooling
>  } // end namespace clang
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory