[cfe-commits] r157500 - in /cfe/trunk: lib/CodeGen/CGCall.cpp test/CodeGenCXX/alloc_size.cpp

[Nuno Lopes]

Author: nlopes
Date: Fri May 25 16:45:08 2012
New Revision: 157500

URL: http://llvm.org/viewvc/llvm-project?rev=157500&view=rev
Log:
fix codegen support for alloc_size attribute for static C++ methods
add test case for C++ codegen

Added:
    cfe/trunk/test/CodeGenCXX/alloc_size.cpp
Modified:
    cfe/trunk/lib/CodeGen/CGCall.cpp

Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCall.cpp?rev=157500&r1=157499&r2=157500&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGCall.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGCall.cpp Fri May 25 16:45:08 2012
@@ -2090,9 +2090,11 @@
   // add metadata for __attribute__((alloc_size(foo)))
   if (TargetDecl) {
     if (const AllocSizeAttr* Attr = TargetDecl->getAttr<AllocSizeAttr>()) {
-      std::vector<llvm::Value*> Args;
+      SmallVector<llvm::Value*, 4> Args;
       llvm::IntegerType *Ty = llvm::IntegerType::getInt32Ty(getLLVMContext());
-      bool isMethod = isa<CXXMethodDecl>(TargetDecl);
+      bool isMethod = false;
+      if (const CXXMethodDecl *MDecl = dyn_cast<CXXMethodDecl>(TargetDecl))
+        isMethod = MDecl->isInstance();
 
       for (AllocSizeAttr::args_iterator I = Attr->args_begin(),
            E = Attr->args_end(); I != E; ++I) {

Added: cfe/trunk/test/CodeGenCXX/alloc_size.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/alloc_size.cpp?rev=157500&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCXX/alloc_size.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/alloc_size.cpp Fri May 25 16:45:08 2012
@@ -0,0 +1,18 @@
+// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s
+
+struct foo {
+  void *my_alloc(unsigned) __attribute__((alloc_size(2)));
+  static void* static_alloc(unsigned) __attribute__((alloc_size(1)));
+};
+
+
+void* f(bool a) {
+  // CHECK: call i8* {{.*}}alloc{{.*}}, !alloc_size !0
+  // CHECK: call i8* {{.*}}static_alloc{{.*}}, !alloc_size !1
+  foo obj;
+  return a ? obj.my_alloc(2) :
+             foo::static_alloc(42);
+}
+
+// CHECK: !0 = metadata !{i32 1}
+// CHECK: !1 = metadata !{i32 0}