[cfe-commits] r157182 -

[David Blaikie]

On Mon, May 21, 2012 at 7:02 AM, Benjamin Kramer
<benny.kra at googlemail.com> wrote:
>
> On 21.05.2012, at 15:10, David Blaikie wrote:
>
>> /cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset="utf-8"
>> Content-Transfer-Encoding: 7bit
>>
>> Test case?
>
> Compile clang with msvc9 and run the regression tests.

Ah, fair enough - I guess one of Takumi's bots caught it, then. Just
so long as something automated does/will catch a regression in the
future.

- David

>> From: Benjamin Kramer
>> Sent: 5/21/2012 3:44 AM
>> To: cfe-commits at cs.uiuc.edu
>> Subject: [cfe-commits] r157182
>> - /cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h
>> Author: d0k
>> Date: Mon May 21 05:42:01 2012
>> New Revision: 157182
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=157182&view=rev
>> Log:
>> Unpack enums in CodeCompletetionResult.
>>
>> In theory they should be wide enough even when the enum type is signed, but it
>> looks like MSVC9 still has problems with it.
>>
>> Modified:
>>    cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h
>>
>> Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h?rev=157182&r1=157181&r2=157182&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h (original)
>> +++ cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h Mon May 21 05:42:01 2012
>> @@ -669,13 +669,13 @@
>>   unsigned StartParameter;
>>
>>   /// \brief The kind of result stored here.
>> -  ResultKind Kind : 3;
>> +  ResultKind Kind;
>>
>>   /// \brief The cursor kind that describes this result.
>> -  CXCursorKind CursorKind : 16;
>> +  CXCursorKind CursorKind;
>>
>>   /// \brief The availability of this result.
>> -  CXAvailabilityKind Availability : 8;
>> +  CXAvailabilityKind Availability;
>>
>>   /// \brief Whether this result is hidden by another name.
>>   bool Hidden : 1;
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>